Skip to content

Use discovery for ML API client instead of static file #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use discovery for ML API client instead of static file #381

wants to merge 3 commits into from

Conversation

cymarechal-devoteam
Copy link

@cymarechal-devoteam cymarechal-devoteam commented Jan 11, 2022 •
edited
Loading

Using CloudTuner previously led to erroneous URLs in API calls, e.g.

https://us-central1-ml.googleapis.com/v1/projects/my-project/locations/europe-west4/studies?studyId=MyStudyID&alt=json

This was due to the static discovery file in src/python/tensorflow_cloud/tuner/api/ml_public_google_rest_v1.json which statically points to https://us-central1-ml.googleapis.com.

This modification aims to remove the static dependency to us-central1 and instead use the dynamic version of Discovery.

Reference:

@cymarechal cymarechal mentioned this pull request Jan 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cymarechal-devoteam